Files
aetherbound-guild/docs/runtime/M43_GUILD_PAGE_VIEW_VISUAL_AUDIT.md
T

7.0 KiB
Raw Blame History

M43 Guild Page View — Source-Bound Visual Audit

Scope and stopping point

M43 extracts the accepted HUB-001 layered Guild desk from entry_shell.gd into the passive, UI-only ABGGuildPageView. The existing world extension, contained 16:9 design canvas, segmented top/bottom rails, two-member muster, engine-rendered Company/pressure/Coin values, contract kiosk, truthful empty / active / returned Contract states, destination locks, focus order and touch areas remain unchanged.

This is a structural View migration only. Contract creation and receipts, Market and Hire transactions, Party, Risk, Battle, economy, Save, localization, assets, audio, packaging and release semantics were not changed. The blocking visual scope is normal 100% landscape. The Owner has explicitly made 130% text scale non-blocking; retained 130% frames are supplemental coverage, not an acceptance blocker.

Product/verification source: 5220acb97dea0259d30c0013a34b9463ff9e5a76 (5220acb, refactor: extract Guild page passive view). Visual baseline source: 975c77db2aa742189fca1edf4c066ab66370c252 (975c77d, M42 closure / M43 activation boundary).

Architecture contract

  • ABGGuildPageView owns only Godot node construction, the contained 16:9 canvas, layered world/rail/actor/kiosk presentation, engine text, local focus and hit areas, and explicit deferred intents.
  • The View consumes a deep-copied GuildPageController.snapshot() ViewData payload. It owns no service, persistence, route state or mutable Company.
  • EntryShell remains the composition root. It translates only these View intents: title, settings, roster, equipment, party, risk, contract, market.
  • GuildPageController remains the copied-facts authority; existing application services remain the transaction/persistence authorities.
  • A source scan in guild_page_view_test.gd rejects forbidden dependencies: GuildContractService, RuntimeContentRegistry, current_screen, entry_shell.gd, res://compat/, Save and company_path.
  • Historical compatibility builders and metadata remain provenance/runtime dependencies where required; no .uid, .import or prototype_incremental/ files were deleted or staged.

Source-bound evidence

All accepted formal attempts used tools/run_test_attempt.py with immutable source archives, owned HOME/cache/TMP/browser roots, strict diagnostics and complete process-group/workspace cleanup. Required terminal markers were checked for exact-once presence.

Check Attempt Result Evidence archive SHA-256
M43-A immutable HUB-001 baseline m43-guild-baseline/20260826T014743Z-34444 PASS; layered reconstruction, DEV-3 Guild flow, four fixture capture terminals and ABG_HUB001_CANDIDATE_OK; 24 captures; strict diagnostics 0; workspace/process removed c8c9c017bbca46eb6fdc2d148af019e4981f4dfcd5102f556215159d8f8ec958
View/controller/runtime focused verification + DEV-3 candidate m43-guild-view-focused-v2/20260826T021613Z-65045 PASS; View contract, M20 controller/runtime, DEV-3 Contract/Market/Hire, M09/M10 regressions, HUB-001 layered reconstruction and candidate; 24 normal-render captures; required markers exact once; strict diagnostics 0; workspace/process removed 19cdb8eb77af91d103ece5d02d6d9072fab96a87544139814b2a2898396ca57e
Full MVP first-cycle audit m43-mvp-audit-v2/20260826T022147Z-70440 PASS; ABG_M43_GUILD_VIEW_CONTRACT_OK and ABG_MVP_FIRST_CYCLE_AUDIT_OK exact once; 128 normal 100% frames / 180 evidence files across first-cycle pages; parsed touch and restart coverage; strict diagnostics 0; workspace/process removed da5cee766bc47a278e02b654a1035644cb7cbf575609787615a566d2e54314f1

The first focused composition (m43-guild-view-focused/20260826T021155Z-60748) was not acceptance evidence: it ran guild_contract_choice_test.gd both before and inside the candidate suite, so ABG_DEV3_GUILD_OK appeared twice. Its product checks and strict diagnostics were clean; the corrected v2 attempt above removes that harness duplication and passes exact-once marker hygiene.

Visual equivalence

The M43-A baseline and the corrected M43 candidate archives contain the same 24 capture filenames (six states × four normal-render fixtures). Every file is byte-identical, and decoded RGBA pixel comparison reports zero differing pixels. The four-fixture family is the established HUB-001 runtime family: two blocking normal 100% fixtures and two retained 130% supplemental fixtures, with the full MVP audit separately covering normal 100% at all three required landscape sizes in both locales.

Fixture Baseline SHA-256 M43 candidate SHA-256 Comparison
760x360 / zh_CN / 100% bd25e8344e6a089cf0a72c0c0bf2567a01f30f4dde649ad4ba3e724cb872d3d8 bd25e8344e6a089cf0a72c0c0bf2567a01f30f4dde649ad4ba3e724cb872d3d8 byte-identical; zero pixel differences
844x390 / en / 100% 00b5df0e97898a10135d3eb194c8c6770f85618d0c0652ffdc3e142c1249aa75 00b5df0e97898a10135d3eb194c8c6770f85618d0c0652ffdc3e142c1249aa75 byte-identical; zero pixel differences
844x390 / zh_CN / 130% (supplemental) 80734d8e3c19f3da85963ef4776a41bf577722daeb253a6ecbf89778435b4e35 80734d8e3c19f3da85963ef4776a41bf577722daeb253a6ecbf89778435b4e35 byte-identical; zero pixel differences
1280x720 / en / 130% (supplemental) d46fd3528d5196a51e473d6f8d316ecde1598c312e813e05a13d7c20079f0616 d46fd3528d5196a51e473d6f8d316ecde1598c312e813e05a13d7c20079f0616 byte-identical; zero pixel differences

The same zero-diff result holds for all 24 Guild/Contract/Market/Recruit Review and receipt-state captures in the candidate family. No visible pixels were added by the View extraction; disabled controls remain disabled and the existing normalized anchors, node identities and focus targets are preserved.

Boundary audit

  • ABGGuildPageView is mounted by show_guild_anchor() after the copied controller snapshot is assembled.
  • EntryShell retains current Company, route transitions, Settings caller context and application/service calls. Enabled destination commands carry no mutable Company payload.
  • Empty Guild enables only Contract; active Contract enables Market, Equipment, Party and Risk; returned Contract keeps later Contract/Market locked. Invalid/missing Company data renders a safe non-interactive fallback.
  • The accepted layered world uses linear-filtered hand-drawn assets and engine-rendered values. No pixel-art conversion, nearest-neighbor filtering or visual redesign was introduced.
  • Focused contract, controller, runtime, layered reconstruction and responsive checks pass at 760x360, 844x390 and 1280x720 with parsed touch targets.

Handoff boundary

M43 closes only the Guild View extraction. Contract Choice, Market, Company/Roster, Party, Risk, Battle, second-cycle systems/content, regions, endgame, device testing, packaging, signing, store/release and human comprehension/fun acceptance remain outside this plan and require their own owner-authorized gate or plan.

ABG M43 GUILD VIEW PILOT COMPLETE