fix(pi): keep archived sessions visible (#1297)

shared/src/sessionSummary.test.ts

@@ -77,6 +77,63 @@ describe('toSessionSummary', () => {
         expect(summary.metadata?.agentSessionId).toBe('grok-session-1')
     })
 
+    it('uses the native id matching the current flavor instead of a stale id', () => {
+        const summary = toSessionSummary(makeSession({
+            metadata: {
+                path: '/proj',
+                host: 'local',
+                flavor: 'cursor',
+                codexSessionId: 'stale-codex-id',
+                cursorSessionId: 'cursor-session-1'
+            }
+        }))
+
+        expect(summary.metadata?.agentSessionId).toBe('cursor-session-1')
+    })
+
+    it('does not fall back to a stale cross-agent id for a known flavor', () => {
+        const summary = toSessionSummary(makeSession({
+            metadata: {
+                path: '/proj',
+                host: 'local',
+                flavor: 'pi',
+                codexSessionId: 'stale-codex-id'
+            }
+        }))
+
+        expect(summary.metadata?.agentSessionId).toBeUndefined()
+    })
+
+    it('includes piSessionId as the native resume token', () => {
+        const summary = toSessionSummary(makeSession({
+            metadata: {
+                path: '/proj',
+                host: 'local',
+                flavor: 'pi',
+                piSessionId: 'pi-session-1'
+            }
+        }))
+
+        expect(summary.metadata?.agentSessionId).toBe('pi-session-1')
+    })
+
+    it.each([
+        undefined,
+        'custom',
+        ' PI '
+    ])('does not infer a Pi identity for an unknown flavor: %s', (flavor) => {
+        const summary = toSessionSummary(makeSession({
+            metadata: {
+                path: '/proj',
+                host: 'local',
+                flavor,
+                piSessionId: 'pi-session-1'
+            }
+        }))
+
+        expect(summary.metadata?.agentSessionId).toBeUndefined()
+    })
+
     it('includes pending request kinds and background task count', () => {
         const summary = toSessionSummary(makeSession({
             backgroundTaskCount: 2,

shared/src/sessionSummary.ts

@@ -1,4 +1,6 @@
-import type { Session, WorktreeMetadata } from './schemas'
+import type { Metadata, Session, WorktreeMetadata } from './schemas'
+import { isKnownFlavor } from './flavors'
+import type { AgentFlavor } from './modes'
 
 export type PendingRequestKind = 'permission' | 'input'
 
@@ -106,6 +108,38 @@ export function getPendingRequestKinds(session: Session): PendingRequestKind[] {
         : Array.from(kinds)
 }
 
+const AGENT_SESSION_ID_FIELD_BY_FLAVOR = {
+    claude: 'claudeSessionId',
+    codex: 'codexSessionId',
+    gemini: 'geminiSessionId',
+    opencode: 'opencodeSessionId',
+    grok: 'grokSessionId',
+    cursor: 'cursorSessionId',
+    kimi: 'kimiSessionId',
+    pi: 'piSessionId'
+} as const satisfies Record<AgentFlavor, keyof Metadata>
+
+function getSummaryAgentSessionId(metadata: Metadata): string | undefined {
+    const flavor = metadata.flavor
+    if (isKnownFlavor(flavor)) {
+        const flavorField = AGENT_SESSION_ID_FIELD_BY_FLAVOR[flavor]
+        const flavorSessionId = metadata[flavorField]
+        return typeof flavorSessionId === 'string' && flavorSessionId.trim()
+            ? flavorSessionId.trim()
+            : undefined
+    }
+
+    // Legacy fallback only applies when the stored flavor is missing or unknown.
+    return metadata.codexSessionId
+        ?? metadata.claudeSessionId
+        ?? metadata.geminiSessionId
+        ?? metadata.opencodeSessionId
+        ?? metadata.grokSessionId
+        ?? metadata.cursorSessionId
+        ?? metadata.kimiSessionId
+        ?? undefined
+}
+
 export function toSessionSummary(session: Session): SessionSummary {
     const pendingRequestsCount = session.agentState?.requests ? Object.keys(session.agentState.requests).length : 0
 
@@ -116,14 +150,7 @@ export function toSessionSummary(session: Session): SessionSummary {
         summary: session.metadata.summary ? { text: session.metadata.summary.text } : undefined,
         flavor: session.metadata.flavor ?? null,
         worktree: session.metadata.worktree,
-        agentSessionId: session.metadata.codexSessionId
-            ?? session.metadata.claudeSessionId
-            ?? session.metadata.geminiSessionId
-            ?? session.metadata.opencodeSessionId
-            ?? session.metadata.grokSessionId
-            ?? session.metadata.cursorSessionId
-            ?? session.metadata.kimiSessionId
-            ?? undefined,
+        agentSessionId: getSummaryAgentSessionId(session.metadata),
         lifecycleState: session.metadata.lifecycleState
     } : null