From 23c0fa487235479ee0cf51277d16650a836b246e Mon Sep 17 00:00:00 2001
From: junes <673638712@qq.com>
Date: Wed, 6 May 2026 05:40:33 +0800
Subject: [PATCH] fix(cli): hide Windows taskkill popups during process cleanup
 (#569)

---
 cli/src/utils/process.ts | 19 +++++++++++++++++--
 1 file changed, 17 insertions(+), 2 deletions(-)

diff --git a/cli/src/utils/process.ts b/cli/src/utils/process.ts
index f19b0877..e2726bc2 100644
--- a/cli/src/utils/process.ts
+++ b/cli/src/utils/process.ts
@@ -17,16 +17,31 @@ export function isProcessAlive(pid: number): boolean {
 }
 
 function killProcessWindows(pid: number, force: boolean): boolean {
+  if (!isProcessAlive(pid)) {
+    return true;
+  }
+
   const args = ['/T', '/PID', pid.toString()];
   if (force) {
     args.unshift('/F');
   }
   try {
-    const result = spawn.sync('taskkill', args, { stdio: 'pipe' });
+    const result = spawn.sync('taskkill', args, {
+      stdio: 'pipe',
+      windowsHide: true
+    });
     if (result.error) {
       return false;
     }
-    return result.status === 0;
+
+    if (result.status === 0) {
+      return true;
+    }
+
+    // Process teardown on Windows is racy: by the time taskkill runs, the target
+    // may already be gone, which commonly surfaces as non-zero exit codes
+    // (including 128 in some shells). Treat this as success if PID is no longer alive.
+    return !isProcessAlive(pid);
   } catch {
     return false;
   }