wushenghua/hapi
1
0
Fork 0
mirror of https://github.com/wu736139669/hapi.git synced 2026-11-11 02:11:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(codex): stabilize goal status updates (#651)

Browse Source
This commit is contained in:
SmallSpider
2026-05-20 11:31:28 +08:00
committed by GitHub
parent 2aaae25d0a
commit 25631d971c
4 changed files with 257 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cli/src/codex/codexRemoteLauncher.test.ts
+51 -4
View File
@@ -23,6 +23,7 @@ const harness = vi.hoisted(() => ({
goalGetCalls: [] as unknown[],
goalClearCalls: [] as unknown[],
goal: null as Record<string, unknown> | null,
suppressGoalNotifications: false,
suppressTurnCompletion: false,
remainingThreadSystemErrors: 0,
startTurnMessages: [] as string[],
@@ -140,8 +141,10 @@ vi.mock('./codexAppServerClient', () => {
updatedAt: 2
};
const notification = { threadId, goal: harness.goal };
harness.notifications.push({ method: 'thread/goal/updated', params: notification });
this.notificationHandler?.('thread/goal/updated', notification);
if (!harness.suppressGoalNotifications) {
harness.notifications.push({ method: 'thread/goal/updated', params: notification });
this.notificationHandler?.('thread/goal/updated', notification);
}
return { goal: harness.goal };
}
@@ -156,8 +159,10 @@ vi.mock('./codexAppServerClient', () => {
harness.goal = null;
if (cleared) {
const notification = { threadId: params?.threadId ?? 'thread-unknown' };
harness.notifications.push({ method: 'thread/goal/cleared', params: notification });
this.notificationHandler?.('thread/goal/cleared', notification);
if (!harness.suppressGoalNotifications) {
harness.notifications.push({ method: 'thread/goal/cleared', params: notification });
this.notificationHandler?.('thread/goal/cleared', notification);
}
}
return { cleared };
}
@@ -946,6 +951,7 @@ describe('codexRemoteLauncher', () => {
harness.goalGetCalls = [];
harness.goalClearCalls = [];
harness.goal = null;
harness.suppressGoalNotifications = false;
harness.suppressTurnCompletion = false;
harness.startTurnMessages = [];
harness.failResumeThreadIds = [];
@@ -1175,6 +1181,9 @@ describe('codexRemoteLauncher', () => {
type: 'message',
message: 'Goal active'
});
expect(sessionEvents).not.toContainEqual({
type: 'ready'
});
expect(codexMessages).toEqual(expect.arrayContaining([
expect.objectContaining({
type: 'thread_goal_updated',
@@ -1206,6 +1215,44 @@ describe('codexRemoteLauncher', () => {
});
});
it('forwards goal RPC responses when the app-server does not emit goal notifications', async () => {
harness.suppressGoalNotifications = true;
const { session, codexMessages } = createSessionStub(['/goal improve benchmark coverage']);
const exitReason = await codexRemoteLauncher(session as never);
expect(exitReason).toBe('exit');
expect(codexMessages).toEqual(expect.arrayContaining([
expect.objectContaining({
type: 'thread_goal_updated',
thread_id: 'thread-1',
goal: expect.objectContaining({
objective: 'improve benchmark coverage',
status: 'active'
})
})
]));
});
it('does not emit ready when a goal command interrupts an active turn', async () => {
harness.suppressTurnCompletion = true;
harness.emitTurnAbortedOnInterrupt = true;
const { session, sessionEvents } = createSessionStub(['first message', '/goal improve benchmark coverage']);
const exitReason = await codexRemoteLauncher(session as never);
expect(exitReason).toBe('exit');
expect(harness.interruptedTurns).toEqual([{ threadId: 'thread-1', turnId: 'turn-1' }]);
expect(harness.goalSetCalls).toEqual([{
threadId: 'thread-1',
objective: 'improve benchmark coverage',
status: 'active'
}]);
expect(sessionEvents).not.toContainEqual({
type: 'ready'
});
});
it('switches collaboration mode to default after approving exit_plan_mode', async () => {
const { session, rpcHandlers, collaborationModes, getCollaborationMode } = createSessionStub(['plan this'], {
permissionMode: 'default',