wushenghua/hapi
1
0
Fork 0
mirror of https://github.com/wu736139669/hapi.git synced 2026-08-05 06:24:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: omit reasoning summary for codex spark subagents (#594)

Browse Source
This commit is contained in:
SmallSpider
2026-05-07 16:44:56 +08:00
committed by GitHub
parent b17269d9e9
commit 293f944724
3 changed files with 112 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cli/src/codex/utils/appServerConfig.ts
+21 -7
View File
@@ -14,9 +14,14 @@ import { resolveCodexPermissionModeConfig } from './permissionModeConfig';
export const codexCollaborationSpawnAgentInstructions = [
'Codex sub-agent spawning rules:',
'- If you call spawn_agent with fork_context: true, do not set agent_type, model, or reasoning_effort; full-history forked agents inherit these values from the parent.',
'- If you need a specific agent_type, model, or reasoning_effort, omit fork_context or set fork_context: false, and include only the necessary context in the message.'
'- If you need a specific agent_type, model, or reasoning_effort, omit fork_context or set fork_context: false, and include only the necessary context in the message.',
'- Do not rely on parent turn reasoning settings for spawned agents; only set reasoning_effort on spawn_agent when the chosen child model supports it.'
].join('\n');
const MODELS_WITHOUT_REASONING_SUMMARY = new Set([
'gpt-5.3-codex-spark'
]);
function resolveApprovalPolicy(mode: EnhancedMode): ApprovalPolicy {
return resolveCodexPermissionModeConfig(mode.permissionMode).approvalPolicy;
}
@@ -42,6 +47,13 @@ function resolveSandboxPolicyOverride(value: CodexCliOverrides['sandbox'] | unde
}
}
export function supportsReasoningSummary(model: string | undefined): boolean {
const normalized = model?.trim().toLowerCase();
if (!normalized) return true;
const modelName = normalized.split('/').pop() ?? normalized;
return !MODELS_WITHOUT_REASONING_SUMMARY.has(modelName);
}
function buildMcpServerConfig(mcpServers: McpServersConfig): Record<string, unknown> {
const config: Record<string, unknown> = {};
@@ -151,13 +163,16 @@ export function buildTurnStartParams(args: {
params.sandboxPolicy = sandboxPolicy;
}
if (args.mode?.modelReasoningEffort) {
params.effort = args.mode.modelReasoningEffort;
params.summary = 'detailed';
}
const collaborationMode = args.mode?.collaborationMode;
const model = args.overrides?.model ?? args.mode?.model;
if (args.mode?.modelReasoningEffort) {
params.effort = args.mode.modelReasoningEffort;
if (!collaborationMode && supportsReasoningSummary(model)) {
params.summary = 'detailed';
}
}
if (collaborationMode) {
if (!model) {
throw new Error(`Collaboration mode '${collaborationMode}' requires a resolved model`);
@@ -167,7 +182,6 @@ export function buildTurnStartParams(args: {
mode: collaborationMode,
settings: {
model,
...(args.mode?.modelReasoningEffort ? { reasoning_effort: args.mode.modelReasoningEffort } : {}),
developer_instructions: appendCollaborationInstructions(developerInstructions)
}
};