From 895922e293ed75e26f57b8105c4102ba129f4f26 Mon Sep 17 00:00:00 2001 From: wusumac <736139669@qq.com> Date: Wed, 16 Sep 2026 22:07:07 +0800 Subject: [PATCH] fix(hub): derive live member status in team detail and team list The stored team_members.status row is only written at join (working) and on session down (offline), so it went stale and the team page chips showed 'working' for idle members while the app sidebar (live session state) showed 'idle'. Team detail / team list now derive status from the live session (thinking -> working, inactive/missing -> offline, blocked preserved). --- hub/src/teams/teamService.test.ts | 38 +++++++++++++++++++++++++++++-- hub/src/teams/teamService.ts | 4 ++-- 2 files changed, 38 insertions(+), 4 deletions(-) diff --git a/hub/src/teams/teamService.test.ts b/hub/src/teams/teamService.test.ts index 4dc5e382..76cba078 100644 --- a/hub/src/teams/teamService.test.ts +++ b/hub/src/teams/teamService.test.ts @@ -487,7 +487,7 @@ describe('TeamService web task management', () => { inWorktree: false }) delivered.length = 0 - return { service, store, team, delivered } + return { service, store, team, delivered, sessions } } it('creates tasks from the web, pushes the brief to the assignee', async () => { @@ -842,9 +842,12 @@ describe('TeamService member down handling', () => { } it('marks the member offline, logs it and wakes the lead', async () => { - const { service, store, team, delivered } = setup() + const { service, store, team, delivered, sessions } = setup() try { await service.handleSessionDown('sess-builder', 'alpha', 'completed') + // The live session is gone: the derived status must be offline even + // if the stored member row was left behind by the down handler. + sessions.delete('sess-builder') const member = service.getTeamDetail(team.id, 'alpha')?.members.find((m) => m.sessionId === 'sess-builder') expect(member?.status).toBe('offline') @@ -1011,3 +1014,34 @@ describe('TeamService settings', () => { } }) }) + +describe('TeamService live member status', () => { + it('derives member status from the live session in team detail', () => { + const { runtime, sessions } = createRuntime() + const store = new TeamStore(':memory:') + const service = new TeamService(store, () => {}, runtime) + try { + const team = service.createTeam('alpha', { name: 'Refactor auth' }) + // Stored rows can be stale ('working' set at spawn time). + store.addMember(team.id, 'sess-builder', 'builder', 'working') + sessions.set('sess-builder', { + id: 'sess-builder', + active: true, + thinking: false, + machineId: 'machine-1', + directory: '/repo', + flavor: 'codex', + inWorktree: false + }) + expect(service.getTeamDetail(team.id, 'alpha')?.members[0]?.status).toBe('idle') + + sessions.set('sess-builder', { ...sessions.get('sess-builder')!, thinking: true }) + expect(service.getTeamDetail(team.id, 'alpha')?.members[0]?.status).toBe('working') + + sessions.delete('sess-builder') + expect(service.getTeamDetail(team.id, 'alpha')?.members[0]?.status).toBe('offline') + } finally { + service.close() + } + }) +}) diff --git a/hub/src/teams/teamService.ts b/hub/src/teams/teamService.ts index 1d58900c..4b8c49c0 100644 --- a/hub/src/teams/teamService.ts +++ b/hub/src/teams/teamService.ts @@ -163,7 +163,7 @@ export class TeamService { listTeamsWithMembers(namespace: string): Array { return this.store.listTeams(namespace).map((team) => ({ ...team, - members: this.store.listMembers(team.id) + members: this.store.listMembers(team.id).map((member) => this.deriveMemberStatus(member)) })) } @@ -172,7 +172,7 @@ export class TeamService { if (!team) return null return { team, - members: this.store.listMembers(team.id), + members: this.store.listMembers(team.id).map((member) => this.deriveMemberStatus(member)), tasks: this.store.listTasks(team.id) } }