feat(web): show hidden directories in workspace browser (#1331)

* feat(web): show hidden directories in workspace browser

Add optional includeHidden param to the machine list-directory RPC so the
WorkspaceBrowser can toggle hidden (dot-prefixed) entries. Default remains
filtered for backward compatibility; the toggle persists via localStorage.

* fix(web): disable show-hidden toggle while directory loading

Prevent overlapping list-directory requests with opposite includeHidden
values; the toggle is now disabled while a directory load is active.
This commit is contained in:
weixiang1862
2026-08-03 12:32:50 +08:00
committed by GitHub
parent a111d0bc82
commit cc39021abc
10 changed files with 138 additions and 21 deletions
+57
View File
@@ -541,3 +541,60 @@ describe('ApiMachineClient keepAlive lifecycle', () => {
expect(priv.keepAliveInterval).toBeNull()
})
})
describe('ApiMachineClient list-directory handler', () => {
let workspaceRoot: string
beforeEach(() => {
ioMock.mockReset()
workspaceRoot = mkdtempSync(join(tmpdir(), 'hapi-machine-ls-'))
mkdirSync(join(workspaceRoot, 'visible-dir'))
mkdirSync(join(workspaceRoot, '.hidden-dir'))
writeFileSync(join(workspaceRoot, 'plain.txt'), 'x')
writeFileSync(join(workspaceRoot, '.hidden-file'), 'x')
})
afterEach(() => {
rmSync(workspaceRoot, { recursive: true, force: true })
})
async function callListDirectory(client: ApiMachineClient, machineId: string, params: { path: string; includeHidden?: boolean }): Promise<unknown> {
const manager = (client as unknown as { rpcHandlerManager: { handleRequest: (req: { method: string; params: string }) => Promise<string> } }).rpcHandlerManager
const raw = await manager.handleRequest({
method: `${machineId}:list-directory`,
params: JSON.stringify(params)
})
return JSON.parse(raw) as unknown
}
function entryNames(result: unknown): string[] {
const entries = (result as { success: boolean; entries?: { name: string }[] }).entries ?? []
return entries.map((entry) => entry.name).sort()
}
it('filters dot-prefixed entries by default', async () => {
const machine = makeMachine('machine-ls-1')
const client = new ApiMachineClient('cli-token', machine, [workspaceRoot])
try {
const result = await callListDirectory(client, machine.id, { path: workspaceRoot })
expect((result as { success: boolean }).success).toBe(true)
expect(entryNames(result)).toEqual(['plain.txt', 'visible-dir'])
} finally {
client.shutdown()
}
})
it('includes dot-prefixed entries when includeHidden is true', async () => {
const machine = makeMachine('machine-ls-2')
const client = new ApiMachineClient('cli-token', machine, [workspaceRoot])
try {
const result = await callListDirectory(client, machine.id, { path: workspaceRoot, includeHidden: true })
expect((result as { success: boolean }).success).toBe(true)
expect(entryNames(result)).toEqual(['.hidden-dir', '.hidden-file', 'plain.txt', 'visible-dir'])
} finally {
client.shutdown()
}
})
})