From d147ae00aadf2678f02c4c4c6429dcbaf8fda01e Mon Sep 17 00:00:00 2001 From: SSU-WEI HUANG Date: Tue, 11 Aug 2026 10:04:18 +0800 Subject: [PATCH] fix(web): rename storageUsagePie helper to storageUsageSlices to avoid macOS case-collision with StorageUsagePie.tsx (#1483) Since #1383 renamed the helper to storageUsagePie.ts, the same directory contained both StorageUsagePie.tsx and storageUsagePie.ts. On case-insensitive filesystems (macOS), extensionless imports of the component resolve to the helper because '.ts' is tried before '.tsx' and 'StorageUsagePie.ts' matches 'storageUsagePie.ts' case-insensitively, breaking typecheck and component tests on macOS. Linux CI is unaffected. Renames the helper (and its test) to storageUsageSlices.ts, which cannot collide, and updates the two importers. Fixes #1482. --- web/src/components/settings/StorageUsagePie.tsx | 2 +- .../{storageUsagePie.test.ts => storageUsageSlices.test.ts} | 2 +- .../settings/{storageUsagePie.ts => storageUsageSlices.ts} | 0 3 files changed, 2 insertions(+), 2 deletions(-) rename web/src/components/settings/{storageUsagePie.test.ts => storageUsageSlices.test.ts} (98%) rename web/src/components/settings/{storageUsagePie.ts => storageUsageSlices.ts} (100%) diff --git a/web/src/components/settings/StorageUsagePie.tsx b/web/src/components/settings/StorageUsagePie.tsx index ae1d0321..3de37513 100644 --- a/web/src/components/settings/StorageUsagePie.tsx +++ b/web/src/components/settings/StorageUsagePie.tsx @@ -7,7 +7,7 @@ import { type StorageUsageBytes, type StorageUsageSlice, type StorageUsageSliceKey, -} from '@/components/settings/storageUsagePie' +} from '@/components/settings/storageUsageSlices' const SLICE_FILL: Record = { database: 'var(--app-link)', diff --git a/web/src/components/settings/storageUsagePie.test.ts b/web/src/components/settings/storageUsageSlices.test.ts similarity index 98% rename from web/src/components/settings/storageUsagePie.test.ts rename to web/src/components/settings/storageUsageSlices.test.ts index 4171a564..a1b35682 100644 --- a/web/src/components/settings/storageUsagePie.test.ts +++ b/web/src/components/settings/storageUsageSlices.test.ts @@ -4,7 +4,7 @@ import { describeDonutArc, formatStoragePercent, polarToCartesian, -} from './storageUsagePie' +} from './storageUsageSlices' describe('buildStorageUsageSlices', () => { it('drops zero-byte sidecars and returns empty when nothing has size', () => { diff --git a/web/src/components/settings/storageUsagePie.ts b/web/src/components/settings/storageUsageSlices.ts similarity index 100% rename from web/src/components/settings/storageUsagePie.ts rename to web/src/components/settings/storageUsageSlices.ts