wushenghua/hapi
1
0
Fork 0
mirror of https://github.com/wu736139669/hapi.git synced 2026-08-08 07:17:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(cli): ping-peer CLI + MCP ping_peer for peer messaging (#1195)

Browse Source 
* feat(cli): add ping-peer CLI and MCP ping_peer for peer messaging

Promote resume-if-inactive + wait-active + POST message into a first-class
CLI command and session MCP tool so agents stop reinventing JWT+curl.

Fixes #1194

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(cli): do not auto-approve MCP ping_peer

Cross-session messaging can resume a peer and inject a prompt, so keep
permission-mode gating (Codex PR review Major on #1195).

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(cli): require approval for ping_peer in read-only mode

Read-only auto-approve treated non-write names as safe; ping_peer can still
resume a peer and inject prompts, so gate it like a write tool.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(cli): keep ping_peer out of Claude --allowedTools

toolNames still registers the MCP tool, but Claude auto-allow must not
pre-approve cross-session resume+inject without a permission prompt.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(cli): re-check session active before ping-peer send

List/get can race; POST /messages still 409s if the target flips inactive
before send. Resume+wait again (and re-gate pi) immediately before POST.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
HeavyGee
2026-07-28 08:36:56 +08:00
committed by GitHub
co-authored by Cursor
parent 84cd9aa3b1
commit e2631a553a
20 changed files with 1241 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cli/src/modules/common/permission/BasePermissionHandler.test.ts
+25
View File
@@ -36,3 +36,28 @@ describe('resolveToolAutoApprovalDecision skill_lookup', () => {
)).toBeNull()
})
})
describe('resolveToolAutoApprovalDecision ping_peer', () => {
it.each([
'ping_peer',
'mcp__hapi__ping_peer',
'hapi_ping_peer',
'Ping Peer Session'
])('does not auto-approve %s in default mode', (toolName) => {
expect(resolveToolAutoApprovalDecision('default', toolName, 'call-1')).toBeNull()
})
it.each([
'ping_peer',
'mcp__hapi__ping_peer',
'hapi_ping_peer',
'Ping Peer Session'
])('does not auto-approve %s in read-only mode', (toolName) => {
expect(resolveToolAutoApprovalDecision('read-only', toolName, 'call-1')).toBeNull()
})
it('still auto-approves unrelated read tools in read-only mode', () => {
expect(resolveToolAutoApprovalDecision('read-only', 'Read', 'call-1')).toBe('approved')
expect(resolveToolAutoApprovalDecision('read-only', 'grep', 'call-2')).toBe('approved')
})
})