From e5a845cf9f7117641bc434b6c8aac7161bd389c0 Mon Sep 17 00:00:00 2001 From: weishu Date: Mon, 26 Oct 2026 14:45:02 +0800 Subject: [PATCH] test(cli): include Codex Auto Review in peer permission coverage --- .../pingPeer/setPeerPermissionMode.test.ts | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/cli/src/modules/pingPeer/setPeerPermissionMode.test.ts b/cli/src/modules/pingPeer/setPeerPermissionMode.test.ts index 3a08f077..a4a6c308 100644 --- a/cli/src/modules/pingPeer/setPeerPermissionMode.test.ts +++ b/cli/src/modules/pingPeer/setPeerPermissionMode.test.ts @@ -34,15 +34,20 @@ function createHttpMock(options: { flavor: string; active: boolean; shared?: boo const base = { accessToken: 'tok', apiUrl: 'http://hub.test' } describe('setPeerPermissionMode', () => { - it('resolves a prefix and posts the mode to the permission-mode route', async () => { - const http = createHttpMock({ flavor: 'codex', active: true }) + it.each([ + { mode: 'yolo', shared: false }, + { mode: 'yolo', shared: true }, + { mode: 'autoReview', shared: false }, + { mode: 'autoReview', shared: true } + ])('resolves a prefix and posts $mode to the permission-mode route (shared: $shared)', async ({ mode, shared }) => { + const http = createHttpMock({ flavor: 'codex', active: true, shared }) - const result = await setPeerPermissionMode({ ...base, sessionIdPrefix: '7d55ed21', mode: 'yolo', http: http as never }) + const result = await setPeerPermissionMode({ ...base, sessionIdPrefix: '7d55ed21', mode, http: http as never }) - expect(result).toEqual({ sessionId, name: 'worker', flavor: 'codex', mode: 'yolo', active: true }) + expect(result).toEqual({ sessionId, name: 'worker', flavor: 'codex', mode, active: true }) expect(http.post).toHaveBeenCalledWith( `http://hub.test/api/sessions/${sessionId}/permission-mode`, - { mode: 'yolo' }, + { mode }, expect.anything() ) }) @@ -55,7 +60,7 @@ describe('setPeerPermissionMode', () => { expect(error).toBeInstanceOf(PingPeerError) expect((error as PingPeerError).code).toBe('bad_args') - expect((error as PingPeerError).message).toContain('allowed: default, read-only, safe-yolo, yolo') + expect((error as PingPeerError).message).toContain('allowed: default, read-only, safe-yolo, autoReview, yolo') expect(http.post).toHaveBeenCalledTimes(1) }) @@ -63,7 +68,7 @@ describe('setPeerPermissionMode', () => { const http = createHttpMock({ flavor: 'codex', active: false, shared: true }) await expect(setPeerPermissionMode({ ...base, sessionIdPrefix: sessionId, mode: 'safe-yolo', http: http as never })) - .rejects.toMatchObject({ code: 'bad_args', message: "invalid mode 'safe-yolo' for codex; allowed: default, read-only, yolo" }) + .rejects.toMatchObject({ code: 'bad_args', message: "invalid mode 'safe-yolo' for codex; allowed: default, read-only, autoReview, yolo" }) expect(http.post).toHaveBeenCalledTimes(1) })