[codex] improve Codex plan mode compatibility (#538)

* fix: improve codex plan mode compatibility

* fix: tighten codex collaboration retry detection

---------

Co-authored-by: weishu <twsxtd@gmail.com>
This commit is contained in:
EthanWang
2026-05-15 22:46:35 +08:00
committed by GitHub
co-authored by weishu
parent be0a41172a
commit f1accabb29
3 changed files with 38 additions and 14 deletions
+12 -9
View File
@@ -266,9 +266,9 @@ class CodexRemoteLauncher extends RemoteLauncherBase {
return false;
}
return message.includes('requires experimentalapi')
|| message.includes('unknown field')
return message.includes('experimentalapi')
|| message.includes('unsupported')
|| message.includes('unknown')
|| message.includes('unrecognized')
|| message.includes('unexpected')
|| message.includes('invalid field');
@@ -278,7 +278,10 @@ class CodexRemoteLauncher extends RemoteLauncherBase {
const record = asRecord(response);
const candidates = [
Array.isArray(response) ? response : undefined,
Array.isArray(record?.data) ? record.data : undefined
Array.isArray(record?.data) ? record.data : undefined,
Array.isArray(record?.modes) ? record.modes : undefined,
Array.isArray(record?.collaborationModes) ? record.collaborationModes : undefined,
Array.isArray(record?.items) ? record.items : undefined
];
for (const candidate of candidates) {
@@ -288,7 +291,9 @@ class CodexRemoteLauncher extends RemoteLauncherBase {
return true;
}
const entryRecord = asRecord(entry);
const mode = asString(entryRecord?.mode) ?? asString(entryRecord?.name);
const mode = asString(entryRecord?.mode)
?? asString(entryRecord?.name)
?? asString(entryRecord?.id);
if (mode === 'plan') {
return true;
}
@@ -2275,7 +2280,6 @@ class CodexRemoteLauncher extends RemoteLauncherBase {
}
});
let supportsTurnCollaborationMode = true;
let supportsPlanCollaborationMode = true;
let supportsGoals = true;
try {
await appServerClient.setExperimentalFeatureEnablement({ enablement: { goals: true } });
@@ -2289,7 +2293,7 @@ class CodexRemoteLauncher extends RemoteLauncherBase {
const hasPlanMode = responseContainsPlanCollaborationMode(response);
logger.debug(`[Codex] collaborationMode/list plan=${hasPlanMode}`);
if (!hasPlanMode) {
supportsPlanCollaborationMode = false;
logger.debug('[Codex] collaborationMode/list did not report plan; will still attempt collaborationMode until rejected');
}
} catch (error) {
logger.debug(`[Codex] collaborationMode/list failed: ${errorMessage(error)}`);
@@ -2735,8 +2739,7 @@ class CodexRemoteLauncher extends RemoteLauncherBase {
model: session.getModel() ?? message.mode.model
};
const shouldSendCollaborationMode = supportsTurnCollaborationMode
&& Boolean(mode.collaborationMode)
&& (mode.collaborationMode !== 'plan' || supportsPlanCollaborationMode);
&& Boolean(mode.collaborationMode);
const buildParams = (suppressCollaborationMode: boolean) => buildTurnStartParams({
threadId: this.currentThreadId!,
message: message.message,
@@ -2749,7 +2752,7 @@ class CodexRemoteLauncher extends RemoteLauncherBase {
});
if (
mode.collaborationMode === 'plan'
&& (!supportsTurnCollaborationMode || !supportsPlanCollaborationMode)
&& !supportsTurnCollaborationMode
) {
session.sendSessionEvent({
type: 'message',