wushenghua/hapi

Fork 0

mirror of https://github.com/wu736139669/hapi.git synced 2026-08-05 06:24:37 +00:00

Files

T

History

55d1bbb7bd feat(cursor): invisible sync-on-open migrator from legacy stream-json to ACP (#844 )

* feat(cursor): invisible sync-on-open migrator from legacy stream-json to ACP

Closes #824

When the operator reopens a legacy stream-json Cursor session in HAPI,
the hub now transparently transplants its `~/.cursor/chats/<wsh>/<uuid>/store.db`
into `~/.cursor/acp-sessions/<uuid>/`, verifies it loads via `agent acp`,
flips `metadata.cursorSessionProtocol = 'acp'`, and removes the legacy
source - all before `resumeSession` returns. Subsequent opens are pure ACP.

The primary justification is safety, not feature parity. #784 (`cursor-agent`
fabricates `Questions skipped by the user` responses in legacy stream-json
mode) still fires regularly in dogfood despite #801's mitigation: the agent
ships destructive side effects against fabricated consent. Migration to ACP
closes the protocol-level door because the `AskQuestion` tool does not exist
on the ACP side, so there is nothing to fabricate.

working. That tradeoff was reasonable at the time. The accumulated #784
evidence makes legacy sessions actively unsafe; this PR makes the upgrade
path invisible enough that users stop avoiding it.

A pre-PR spike established that legacy and ACP `store.db` files use the
identical SQLite schema; only the directory layout differs. The migrator
therefore:

1. Sanity-checks the source store and pre-flips state (`session.active`,
   `lifecycleState`, on-disk presence, target collision)
2. Optionally archives a stale-running row (`forceArchiveRunning: true` is
   the default for the auto-migrate path because the caller already
   verified `session.active === false`)
3. Atomically creates `~/.cursor/acp-sessions/<uuid>/` with mode `0o700`
4. Copies `store.db` and chmods to `0o600` (multi-user-host hardening)
5. Writes a minimal `meta.json` sidecar (`schemaVersion`, `cwd`, optional
   `title`) with mode `0o600`
6. Spawns `agent acp` under HAPI_HOME isolation and verifies the session
   loads via `session/load`. On long histories the verify also drives a
   trivial single-turn prompt; on short ones load-only is enough
7. Flips `cursorSessionProtocol = 'acp'` AND clears the
   `cursorMigrationState` banner flag in a SINGLE metadata write
8. Removes the legacy source store (only after verify succeeded and the
   protocol flip committed). The legacy `~/.cursor/chats` parent dir is
   left as-is

Every failure leaves the legacy state intact. No `rm` fires without a
verify success AND a committed protocol flip.

The transplant takes 15-20s on long histories (copy a multi-hundred-MB
store, spawn `agent acp`, replay thousands of notifications, tear down
the probe). Without a progress indicator the wait reads as "broken" to a
fresh reviewer. A minimal banner ships alongside the migrator:

- Hub sets `metadata.cursorMigrationState = 'in_progress'` BEFORE the
  long-running transplant. The session-cache refresh emits the existing
  `session-updated` SSE event (no new event type), so the web client
  picks it up in milliseconds. No client-side polling needed.
- Hub clears the flag in the SAME metadata write that flips
  `cursorSessionProtocol` to `'acp'` on success, so the banner disappears
  in the same render tick the chat re-renders as ACP - no flicker window.
- Hub clears the flag explicitly in the auto-migrate helper's `finally`
  on failure/exception, so the banner never gets stuck if migration
  falls back to the legacy launcher.
- Web renders an accessible (role=status, aria-live=polite) banner with
  an indeterminate spinner. Deliberately no fake percentage - we do not
  have phase data and a fake progress bar would lie.

This PR is intentionally sequenced AFTER swear01's three ACP mop-up PRs
(merged today as ad038bbf, 8094b500, fa363c2f), all of which are
prerequisite for safe concurrent ACP launches.

The verify probe spawns `agent acp` directly via `AcpVerifyProbe` under
HAPI_HOME isolation (the migrator overrides `HOME` to a temp dir for the
verify pass), so it never touches `<real-HAPI_HOME>/locks/agent-acp-active/`
at all. Per swear01's #835 design note, the post-flip ACP launcher claims
the lock through the standard `registerActiveAcpTransport` entry and
behaves like any other concurrent ACP start. The migrator itself never
writes `pid` or `count` files directly.

The auto-migrate path is gated by `HAPI_CURSOR_LEGACY_AUTO_MIGRATE`. Set
to `0`, `false`, `no`, or `off` to suppress it entirely (legacy sessions
keep running through the existing stream-json launcher). Default is on.

A REST endpoint at `POST /api/sessions/:id/migrate-to-acp` allows
explicit migration of a single session outside the sync-on-open path
(e.g. for a specific cold archived session a user wants to re-engage).
Bulk migration surfaces (CLI subcommand, web button, bulk REST endpoint,
candidate-listing API) were deliberately stripped per reviewer feedback;
per-session sync-on-open + this escape hatch are the only two paths.

- 343 hub unit tests (4 new for the migration banner flag transitions,
  53 for the migrator core, 32 for the verify probe, 15 for the auto-
  migrate helper guard matrix, plus existing suites)
- 3 integration tests against a real `agent acp` (skipped by default
  unless `HAPI_CURSOR_LEGACY_MIGRATOR_INTEGRATION=1`)
- 10 web unit tests for the banner component (visibility paths + a11y)
- Typecheck clean across cli, web, hub

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(cursor): address upstream Codex review findings on #844 (2 majors)

Finding 1 (Major) — verify probe `agentLookupHome` ignored `metadata.homeDir`
in service-account hub deployments. `migrateOne` resolved the legacy store
under `metadata.homeDir` (the recorded session-owner home) but the default
createProbe factory still set `agentLookupHome` from `this.deps.homeDir()`
(the hub user's home). On a service-account hub, the store lookup
succeeded but `agent acp` discovery fell back to the hub user's
`~/.local/bin`, so verify silently failed and sync-on-open quietly fell
back to legacy.

Fix:
- Widen `CursorLegacyMigratorDeps.createProbe` signature from
  `(env) => AcpVerifyProbe` to `(env, agentLookupHome) => AcpVerifyProbe`
- Default factory uses the passed `agentLookupHome`
- `verifyInTempHome` threads `opts.sourceHome` (already the resolved
  session-owner home) through as the 2nd arg

2 new regression tests pin the contract:
- service-account case (metadata.homeDir != deps.homeDir()): captured
  agentLookupHome MUST equal metadata.homeDir
- legacy session record (no metadata.homeDir): falls back to
  deps.homeDir() correctly

Finding 2 (Major) — `bun.lock` win32-x64 pinned to 0.20.0 while
`cli/package.json` required 0.20.1 (rebase artifact from the v0.20.0 →
v0.20.1 release commit landing in upstream/main between the original
spike and the rebase). Frozen-install Windows users would either get
the wrong native binary or have the lock rejected.

Fix: regenerated bun.lock so the entry resolves
`@twsxtd/hapi-win32-x64@0.20.1`. `bun install --frozen-lockfile` now
passes clean.

Test budget:
- 391 hub unit tests pass (2 new for createProbe agentLookupHome
  contract, +0 regressions)
- Typecheck clean across cli + web + hub
- `bun install --frozen-lockfile` clean

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>

2026-06-10 13:57:55 +08:00

scripts

Clean up cross-package build coupling

2026-05-20 19:29:43 +08:00

src

feat(cursor): invisible sync-on-open migrator from legacy stream-json to ACP (#844 )

2026-06-10 13:57:55 +08:00

package.json

Clean up cross-package build coupling

2026-05-20 19:29:43 +08:00

README.md

feat(claude): add effort setting parity with model across stack (#353 )

2026-03-24 21:15:48 +08:00

tsconfig.json

feat: rename server package to hub

2026-01-27 19:51:21 +08:00

README.md

hapi-hub

Telegram bot + HTTP API + realtime updates for hapi hub.

What it does

Telegram bot for notifications and the Mini App entrypoint.
HTTP API for sessions, messages, permissions, machines, and files.
Server-Sent Events stream for live updates in the web app.
Socket.IO channel for CLI connections.
Serves the web app from web/dist or embedded assets in the single binary.
Persists state in SQLite.

Configuration

See src/configuration.ts for all options.

Required

CLI_API_TOKEN - Base shared secret used by CLI and web login. Clients append :<namespace> for isolation. Auto-generated on first run if not set.

Optional (Telegram)

TELEGRAM_BOT_TOKEN - Token from @BotFather.
HAPI_PUBLIC_URL - Public HTTPS URL for Telegram Mini App access. Also used to derive default CORS origins for the web app.

Optional (Voice)

ELEVENLABS_API_KEY - ElevenLabs API key for voice assistant.
ELEVENLABS_AGENT_ID - Custom ElevenLabs agent ID (auto-created if not set).

Optional

HAPI_LISTEN_HOST - HTTP bind address (default: 127.0.0.1).
HAPI_LISTEN_PORT - HTTP port (default: 3006).
CORS_ORIGINS - Comma-separated origins, or *.
HAPI_HOME - Data directory (default: ~/.hapi).
DB_PATH - SQLite database path (default: HAPI_HOME/hapi.db).
TELEGRAM_NOTIFICATION - Enable/disable Telegram notifications (default: true).
HAPI_RELAY_API - Relay API domain (default: relay.hapi.run).
HAPI_RELAY_AUTH - Relay auth key (default: hapi).
HAPI_RELAY_FORCE_TCP - Force TCP relay mode (true/1).
VAPID_SUBJECT - Contact email/URL for Web Push.

Running

Binary (single executable):

export TELEGRAM_BOT_TOKEN="..."
export CLI_API_TOKEN="shared-secret"
export HAPI_PUBLIC_URL="https://your-domain.example"

hapi hub

hapi server remains supported as an alias.

If you only need web + CLI, you can omit TELEGRAM_BOT_TOKEN. To enable Telegram, set TELEGRAM_BOT_TOKEN and HAPI_PUBLIC_URL, start the hub, open /app in the bot chat, and bind the Mini App with CLI_API_TOKEN:<namespace> when prompted.

From source:

bun install
bun run dev:hub

HTTP API

See src/web/routes/ for all endpoints.

Authentication (`src/web/routes/auth.ts`)

POST /api/auth - Get JWT token (Telegram initData or CLI_API_TOKEN[:namespace]).
POST /api/bind - Bind a Telegram account using initData + CLI_API_TOKEN:<namespace>.

Sessions (`src/web/routes/sessions.ts`)

GET /api/sessions - List all sessions.
GET /api/sessions/:id - Get session details.
POST /api/sessions/:id/abort - Abort session.
POST /api/sessions/:id/switch - Switch session to remote mode.
POST /api/sessions/:id/resume - Resume inactive session.
POST /api/sessions/:id/upload - Upload file (base64, max 50MB).
POST /api/sessions/:id/upload/delete - Delete uploaded file.
POST /api/sessions/:id/archive - Archive active session.
PATCH /api/sessions/:id - Rename session.
DELETE /api/sessions/:id - Delete inactive session.
GET /api/sessions/:id/slash-commands - List slash commands.
GET /api/sessions/:id/skills - List skills.
POST /api/sessions/:id/permission-mode - Set permission mode.
POST /api/sessions/:id/model - Set model preference.
POST /api/sessions/:id/effort - Set Claude effort preference.

Messages (`src/web/routes/messages.ts`)

GET /api/sessions/:id/messages - Get messages (paginated).
POST /api/sessions/:id/messages - Send message.

Permissions (`src/web/routes/permissions.ts`)

POST /api/sessions/:id/permissions/:requestId/approve - Approve permission.
POST /api/sessions/:id/permissions/:requestId/deny - Deny permission.

Machines (`src/web/routes/machines.ts`)

GET /api/machines - List online machines.
POST /api/machines/:id/spawn - Spawn new session on machine.
POST /api/machines/:id/paths/exists - Check if path exists.

Git/Files (`src/web/routes/git.ts`)

GET /api/sessions/:id/git-status - Git status.
GET /api/sessions/:id/git-diff-numstat - Diff summary.
GET /api/sessions/:id/git-diff-file - File-specific diff.
GET /api/sessions/:id/file - Read file content.
GET /api/sessions/:id/files - File search with ripgrep.

Events (`src/web/routes/events.ts`)

GET /api/events - SSE stream for live updates.
POST /api/visibility - Report client visibility state.

Voice (`src/web/routes/voice.ts`)

POST /api/voice/token - Get ElevenLabs conversation token.

Push Notifications (`src/web/routes/push.ts`)

GET /api/push/vapid-public-key - Get VAPID public key.
POST /api/push/subscribe - Subscribe to push notifications.
DELETE /api/push/subscribe - Unsubscribe.

CLI (`src/web/routes/cli.ts`)

POST /cli/sessions - Create/load session.
GET /cli/sessions/:id - Get session by ID.
POST /cli/machines - Create/load machine.
GET /cli/machines/:id - Get machine by ID.

Socket.IO

See src/socket/handlers/cli.ts for event handlers.

Namespace: /cli

Client events (CLI to hub)

message - Send message to session.
update-metadata - Update session metadata.
update-state - Update agent state.
session-alive - Keep session active.
session-end - Mark session ended.
machine-alive - Keep machine online.
rpc-register - Register RPC handler.
rpc-unregister - Unregister RPC handler.

Terminal events (web to hub)

terminal:create - Open terminal for session.
terminal:write - Send input.
terminal:resize - Resize dimensions.
terminal:close - Close terminal.

Hub events (hub to clients)

update - Broadcast session/message updates.
rpc-request - Incoming RPC call.

See src/socket/rpcRegistry.ts for RPC routing.

Telegram Bot

See src/telegram/bot.ts for bot implementation.

Commands

/start - Welcome message with Mini App link.
/app - Open Mini App.

Features

Permission request notifications with approve/deny buttons.
Session ready notifications.
Deep links to Mini App sessions.

See src/telegram/callbacks.ts for button handlers.

Core Logic

See src/sync/syncEngine.ts for the main session/message manager:

In-memory session cache with versioning.
Message pagination and retrieval.
Permission approval/denial.
RPC method routing via Socket.IO.
Event publishing to SSE and Telegram.
Git operations and file search.
Activity tracking and timeouts.

Storage

See src/store/index.ts for SQLite persistence:

Sessions with metadata and agent state.
Messages with pagination support.
Machines with runner state.
Todo extraction from messages.
Users table for Telegram bindings (includes namespace).

Source structure

src/web/ - HTTP service and routes.
src/socket/ - Socket.IO setup and handlers.
src/socket/handlers/cli/ - Modular CLI handlers.
src/telegram/ - Telegram bot.
src/sync/ - Core session/message logic.
src/store/ - SQLite persistence.
src/sse/ - Server-Sent Events.
src/config/ - Configuration loading and generation.
src/notifications/ - Push and Telegram notifications.
src/visibility/ - Client visibility tracking.

Security model

Access is controlled by:

Telegram initData verification plus bound Telegram users (bound via CLI_API_TOKEN:<namespace>).
CLI_API_TOKEN base secret for CLI and browser access (namespace is appended by clients).

Transport security depends on HTTPS in front of the hub.

Build for deployment

From the repo root:

bun run build:hub
bun run build:web

The hub build output is hub/dist/index.js, and the web assets are in web/dist.

Networking notes

Telegram Mini Apps require HTTPS and a public URL. If the hub has no public IP, use Cloudflare Tunnel or Tailscale and set HAPI_PUBLIC_URL to the HTTPS endpoint.
If the web app is hosted on a different origin, set CORS_ORIGINS (or HAPI_PUBLIC_URL) to include that static host origin.

Standalone web hosting

The web UI can be hosted separately from the hub (for example on GitHub Pages or Cloudflare Pages):

Build and deploy web/dist from the repo root.
Set CORS_ORIGINS (or HAPI_PUBLIC_URL) to the static host origin.
Open the static site, click the Hub button on the login screen, and enter the hapi hub origin.

Leaving the hub override empty preserves the default same-origin behavior when the hub serves the web assets directly.

README.md

hapi-hub

What it does

Configuration

Required

Optional (Telegram)

Optional (Voice)

Optional

Running

HTTP API

Authentication (src/web/routes/auth.ts)

Sessions (src/web/routes/sessions.ts)

Messages (src/web/routes/messages.ts)

Permissions (src/web/routes/permissions.ts)

Machines (src/web/routes/machines.ts)

Git/Files (src/web/routes/git.ts)

Events (src/web/routes/events.ts)

Voice (src/web/routes/voice.ts)

Push Notifications (src/web/routes/push.ts)

CLI (src/web/routes/cli.ts)

Socket.IO

Client events (CLI to hub)

Terminal events (web to hub)

Hub events (hub to clients)

Telegram Bot

Commands

Features

Core Logic

Storage

Source structure

Security model

Build for deployment

Networking notes

Standalone web hosting

Authentication (`src/web/routes/auth.ts`)

Sessions (`src/web/routes/sessions.ts`)

Messages (`src/web/routes/messages.ts`)

Permissions (`src/web/routes/permissions.ts`)

Machines (`src/web/routes/machines.ts`)

Git/Files (`src/web/routes/git.ts`)

Events (`src/web/routes/events.ts`)

Voice (`src/web/routes/voice.ts`)

Push Notifications (`src/web/routes/push.ts`)

CLI (`src/web/routes/cli.ts`)