mirror of
https://github.com/wu736139669/hapi.git
synced 2026-11-18 03:27:08 +00:00
* feat(web): drag-and-drop files onto chat panel to add as attachments Closes #935 Adds a `useDragOver` hook that detects when a file is being dragged over the browser window and suppresses the browser's default file-open behaviour for drops outside the accept zone. A new `DragDropZone` component wraps the inner `AssistantRuntimeProvider` content in `SessionChat`. It shows a semi-transparent overlay (dashed border + "Drop to attach" label) on the right-side chat panel as soon as any file drag is detected — regardless of where the pointer is on the page. Dropping on the right panel adds the files as composer attachments via the existing `api.composer().addAttachment()` path. Drops on the left sidebar are suppressed (no navigation, no attachment). via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run> * fix(web): disable drag-drop zone when pendingSchedule is active The backend rejects requests with both scheduledAt and attachments. DragDropZone now respects pendingSchedule the same way paste and the attach button do — disabled=true suppresses the overlay, sets dropEffect='none', and skips addAttachment on drop. via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run> * fix(web): harden drag-drop default-action handling Address HAPI Bot review on #936: - useDragOver: cancel the browser's default file-open/navigation on the document-level `drop` event for file payloads, not only on `dragover`. Preventing default on `dragover` alone still lets the browser open a file dropped outside any zone (e.g. the sidebar), which could unload the app. - DragDropZone: only preventDefault when the drop payload actually contains files, so non-file drops (e.g. dragging selected text into the composer) keep their default browser behaviour. Add regression tests for both. via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(web): use Simplified Chinese for composer.dropToAttach in zh-CN Address HAPI Bot review on #936: the new zh-CN string used Traditional Chinese forms (放開以附加檔案) in the Simplified Chinese locale, which is inconsistent with neighbouring keys (e.g. composer.attach = 添加文件). Use 松开以添加文件 to match. via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: HAPI <noreply@hapi.run> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
63 lines
2.1 KiB
TypeScript
63 lines
2.1 KiB
TypeScript
import { describe, it, expect } from 'vitest'
|
|
import { renderHook, act } from '@testing-library/react'
|
|
import { useDragOver } from './useDragOver'
|
|
|
|
function makeDragEvent(type: string, types: string[]): Event {
|
|
const event = new Event(type, { bubbles: true, cancelable: true })
|
|
Object.defineProperty(event, 'dataTransfer', {
|
|
value: { types },
|
|
configurable: true,
|
|
})
|
|
return event
|
|
}
|
|
|
|
describe('useDragOver', () => {
|
|
it('prevents the browser default when a file is dropped outside a zone', () => {
|
|
// Regression: a file dropped on the document (e.g. the sidebar) must not
|
|
// trigger the browser's file-open/navigation behaviour.
|
|
const { unmount } = renderHook(() => useDragOver())
|
|
const event = makeDragEvent('drop', ['Files'])
|
|
act(() => {
|
|
document.dispatchEvent(event)
|
|
})
|
|
expect(event.defaultPrevented).toBe(true)
|
|
unmount()
|
|
})
|
|
|
|
it('does not prevent default for a non-file drop', () => {
|
|
const { unmount } = renderHook(() => useDragOver())
|
|
const event = makeDragEvent('drop', ['text/plain'])
|
|
act(() => {
|
|
document.dispatchEvent(event)
|
|
})
|
|
expect(event.defaultPrevented).toBe(false)
|
|
unmount()
|
|
})
|
|
|
|
it('also prevents default on dragover for files so the drop can be cancelled', () => {
|
|
const { unmount } = renderHook(() => useDragOver())
|
|
const event = makeDragEvent('dragover', ['Files'])
|
|
act(() => {
|
|
document.dispatchEvent(event)
|
|
})
|
|
expect(event.defaultPrevented).toBe(true)
|
|
unmount()
|
|
})
|
|
|
|
it('tracks file-drag state and clears it on drop', () => {
|
|
const { result, unmount } = renderHook(() => useDragOver())
|
|
expect(result.current).toBe(false)
|
|
|
|
act(() => {
|
|
document.dispatchEvent(makeDragEvent('dragenter', ['Files']))
|
|
})
|
|
expect(result.current).toBe(true)
|
|
|
|
act(() => {
|
|
document.dispatchEvent(makeDragEvent('drop', ['Files']))
|
|
})
|
|
expect(result.current).toBe(false)
|
|
unmount()
|
|
})
|
|
})
|