Files
hapi/cli/src/agent/permissionAdapter.ts
T
3a8693f380 feat(cursor): migrate remote sessions to ACP with model/variant pickers (#799)
* feat(cli,web,hub): migrate Cursor remote sessions to ACP with model/effort pickers

Move stream-json remote launcher to legacy path and add ACP launcher with
set_config_option model/mode sync, optimistic keepalive on config changes, and
shared catalog caching. Web gets dual base/effort Cursor pickers for session and
new-session flows; hide composer status bar when Cursor sends no usage_update.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(cli,web,shared): Cursor model picker — ACP wires + CLI sku variants

Enrich the web/mobile picker with agent --list-models SKUs grouped under
ACP wire bases, fix session-open base highlight, and keep catalog discovery
safe while the ACP transport holds the CLI lock.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(cursor-acp): apply ACP default model when web resets to Default

Web sends model: null for Default; push session/set_config_option with the
ACP default[] wire so Cursor backend matches hub state. Regression tests
for setModel(null) and applyModelConfig(null).

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(acp): clear stale agent-acp lock when owning process is gone

Check lock pid with signal 0; remove orphaned lock dirs after SIGKILL or
crash so listCursorModels can run cold probes again. Regression tests for
guard and catalog discovery.

Co-authored-by: Cursor <cursoragent@cursor.com>

* test(cursor): use live pid for ACP lock handler tests

Stale-lock cleanup clears dead pids; handler tests must simulate an
active lock with the current process pid to avoid cold probes/timeouts.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(acp): scope agent CLI lock guard to Cursor agent command only

Gemini/OpenCode/Kimi ACP sessions must not register agent-acp-active;
that blocked listCursorModels while unrelated backends were running.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(hub,web): reject Cursor model changes for local sessions

Hub returns 409 when controlledByUser is set, matching Codex. Web hides
model and variant pickers for local Cursor sessions so users do not hit
a dead RPC path. Document pre-push-review in AGENTS.md.

Verified: bun typecheck; bun run test (919 cli + 243 hub + 768 web + 46 shared).
Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(web): send stable ids for Cursor ask_question replies

Parse and submit question.id and option.id so ACP receives keys like
{ approach: ['a'] } instead of index/label. Verified: bun typecheck && bun run test.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-06-06 19:51:35 +08:00

244 lines
8.7 KiB
TypeScript

import type { AgentBackend, PermissionRequest, PermissionResponse } from './types';
import type { AgentState, SessionPermissionMode } from '@/api/types';
import type { ApiSessionClient } from '@/api/apiSession';
import { logger } from '@/ui/logger';
import { deriveToolName } from '@/agent/utils';
import { RPC_METHODS } from '@hapi/protocol/rpcMethods';
import {
resolveToolAutoApprovalDecision,
type AutoApprovalDecision
} from '@/modules/common/permission/BasePermissionHandler';
interface PermissionResponseMessage {
id: string;
approved: boolean;
decision?: 'approved' | 'approved_for_session' | 'denied' | 'abort';
}
function deriveToolInput(request: PermissionRequest): unknown {
if (request.rawInput !== undefined) {
return request.rawInput;
}
return request.rawOutput;
}
function pickOptionId(
request: PermissionRequest,
preferredKinds: string[],
options?: { fallbackToFirst?: boolean }
): string | null {
for (const kind of preferredKinds) {
const match = request.options.find((option) => option.kind === kind);
if (match) return match.optionId;
}
if (options?.fallbackToFirst === false) {
return null;
}
return request.options.length > 0 ? request.options[0].optionId : null;
}
export class PermissionAdapter {
private readonly pendingRequests = new Map<string, PermissionRequest>();
constructor(
private readonly session: ApiSessionClient,
private readonly backend: AgentBackend,
private readonly getPermissionMode?: () => SessionPermissionMode | undefined,
private readonly interceptPermissionResponse?: (response: PermissionResponseMessage) => Promise<boolean>
) {
this.backend.onPermissionRequest((request) => this.handlePermissionRequest(request));
this.session.rpcHandlerManager.registerHandler<PermissionResponseMessage, void>(
RPC_METHODS.Permission,
async (response) => {
if (this.interceptPermissionResponse) {
const handled = await this.interceptPermissionResponse(response);
if (handled) {
return;
}
}
await this.handlePermissionResponse(response);
}
);
}
private handlePermissionRequest(request: PermissionRequest): void {
const toolName = deriveToolName({
title: request.title,
kind: request.kind,
rawInput: request.rawInput
});
const input = deriveToolInput(request);
const mode = this.getPermissionMode?.();
const autoDecision = resolveToolAutoApprovalDecision(mode, toolName, request.toolCallId);
if (autoDecision) {
void this.autoApproveRequest(request, toolName, input, autoDecision);
return;
}
this.pendingRequests.set(request.id, request);
this.session.updateAgentState((currentState) => ({
...currentState,
requests: {
...currentState.requests,
[request.id]: {
tool: toolName,
arguments: input,
createdAt: Date.now()
}
}
}));
logger.debug(`[ACP] Permission request queued: ${toolName} (${request.id})`);
}
private async autoApproveRequest(
request: PermissionRequest,
toolName: string,
input: unknown,
decision: AutoApprovalDecision
): Promise<void> {
const optionId = pickOptionId(
request,
decision === 'approved_for_session'
? ['allow_always', 'allow_once']
: ['allow_once', 'allow_always'],
{ fallbackToFirst: false }
);
const outcome: PermissionResponse = optionId
? { outcome: 'selected', optionId }
: { outcome: 'cancelled' };
await this.backend.respondToPermission(request.sessionId, request, outcome);
const timestamp = Date.now();
const status = outcome.outcome === 'selected' ? 'approved' : 'canceled';
this.session.updateAgentState((currentState) => ({
...currentState,
completedRequests: {
...currentState.completedRequests,
[request.id]: {
tool: toolName,
arguments: input,
createdAt: timestamp,
completedAt: timestamp,
status,
decision: outcome.outcome === 'selected' ? decision : 'abort'
}
}
} satisfies AgentState));
logger.debug(
`[ACP] Auto-${outcome.outcome === 'selected' ? 'approved' : 'cancelled'} ` +
`${toolName} (${request.id}) with decision=${decision}`
);
}
private async handlePermissionResponse(response: PermissionResponseMessage): Promise<void> {
const pending = this.pendingRequests.get(response.id);
if (!pending) {
logger.debug('[ACP] Permission response received for unknown request', response.id);
return;
}
this.pendingRequests.delete(response.id);
const decision = response.decision ?? (response.approved ? 'approved' : 'denied');
const toolName = deriveToolName({
title: pending.title,
kind: pending.kind,
rawInput: pending.rawInput
});
const toolInput = deriveToolInput(pending);
const outcome = this.mapDecisionToOutcome(pending, decision);
if (decision === 'abort') {
await this.backend.cancelPrompt(pending.sessionId);
await this.backend.respondToPermission(pending.sessionId, pending, { outcome: 'cancelled' });
await this.cancelAll('User aborted');
} else if (outcome) {
await this.backend.respondToPermission(pending.sessionId, pending, outcome);
}
this.session.updateAgentState((currentState) => {
const requestEntry = currentState.requests?.[response.id];
const { [response.id]: _, ...remaining } = currentState.requests ?? {};
const status = response.approved ? 'approved' : 'denied';
return {
...currentState,
requests: remaining,
completedRequests: {
...currentState.completedRequests,
[response.id]: {
tool: toolName,
arguments: toolInput,
createdAt: requestEntry?.createdAt ?? Date.now(),
completedAt: Date.now(),
status,
decision
}
}
} satisfies AgentState;
});
logger.debug(`[ACP] Permission ${response.approved ? 'approved' : 'denied'} for ${toolName}`);
}
private mapDecisionToOutcome(
request: PermissionRequest,
decision: 'approved' | 'approved_for_session' | 'denied' | 'abort'
): PermissionResponse | null {
if (decision === 'abort') {
return { outcome: 'cancelled' };
}
if (decision === 'approved_for_session') {
const optionId = pickOptionId(request, ['allow_always', 'allow_once']);
return optionId ? { outcome: 'selected', optionId } : { outcome: 'cancelled' };
}
if (decision === 'approved') {
const optionId = pickOptionId(request, ['allow_once', 'allow_always']);
return optionId ? { outcome: 'selected', optionId } : { outcome: 'cancelled' };
}
const optionId = pickOptionId(request, ['reject_once', 'reject_always']);
return optionId ? { outcome: 'selected', optionId } : { outcome: 'cancelled' };
}
async cancelAll(reason: string): Promise<void> {
const pending = Array.from(this.pendingRequests.values());
this.pendingRequests.clear();
for (const request of pending) {
await this.backend.respondToPermission(request.sessionId, request, { outcome: 'cancelled' });
}
this.session.updateAgentState((currentState) => {
const pendingRequests = currentState.requests ?? {};
const completedRequests = { ...currentState.completedRequests };
for (const [id, request] of Object.entries(pendingRequests)) {
completedRequests[id] = {
...request,
completedAt: Date.now(),
status: 'canceled',
reason,
decision: 'abort'
};
}
return {
...currentState,
requests: {},
completedRequests
};
});
}
}