Files
hapi/cli/src/cursor/cursorRemoteLauncher.test.ts
T
3a8693f380 feat(cursor): migrate remote sessions to ACP with model/variant pickers (#799)
* feat(cli,web,hub): migrate Cursor remote sessions to ACP with model/effort pickers

Move stream-json remote launcher to legacy path and add ACP launcher with
set_config_option model/mode sync, optimistic keepalive on config changes, and
shared catalog caching. Web gets dual base/effort Cursor pickers for session and
new-session flows; hide composer status bar when Cursor sends no usage_update.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(cli,web,shared): Cursor model picker — ACP wires + CLI sku variants

Enrich the web/mobile picker with agent --list-models SKUs grouped under
ACP wire bases, fix session-open base highlight, and keep catalog discovery
safe while the ACP transport holds the CLI lock.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(cursor-acp): apply ACP default model when web resets to Default

Web sends model: null for Default; push session/set_config_option with the
ACP default[] wire so Cursor backend matches hub state. Regression tests
for setModel(null) and applyModelConfig(null).

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(acp): clear stale agent-acp lock when owning process is gone

Check lock pid with signal 0; remove orphaned lock dirs after SIGKILL or
crash so listCursorModels can run cold probes again. Regression tests for
guard and catalog discovery.

Co-authored-by: Cursor <cursoragent@cursor.com>

* test(cursor): use live pid for ACP lock handler tests

Stale-lock cleanup clears dead pids; handler tests must simulate an
active lock with the current process pid to avoid cold probes/timeouts.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(acp): scope agent CLI lock guard to Cursor agent command only

Gemini/OpenCode/Kimi ACP sessions must not register agent-acp-active;
that blocked listCursorModels while unrelated backends were running.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(hub,web): reject Cursor model changes for local sessions

Hub returns 409 when controlledByUser is set, matching Codex. Web hides
model and variant pickers for local Cursor sessions so users do not hit
a dead RPC path. Document pre-push-review in AGENTS.md.

Verified: bun typecheck; bun run test (919 cli + 243 hub + 768 web + 46 shared).
Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(web): send stable ids for Cursor ask_question replies

Parse and submit question.id and option.id so ACP receives keys like
{ approach: ['a'] } instead of index/label. Verified: bun typecheck && bun run test.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-06-06 19:51:35 +08:00

104 lines
3.5 KiB
TypeScript

import { describe, expect, it, vi, beforeEach } from 'vitest';
import type { Metadata } from '@hapi/protocol/schemas';
import type { CursorSession } from './session';
const legacyLauncher = vi.hoisted(() => vi.fn(async () => 'exit' as const));
const acpLauncher = vi.hoisted(() => vi.fn(async () => 'exit' as const));
vi.mock('./cursorLegacyRemoteLauncher', () => ({
cursorLegacyRemoteLauncher: legacyLauncher
}));
vi.mock('./cursorAcpRemoteLauncher', () => ({
cursorAcpRemoteLauncher: acpLauncher
}));
import { cursorRemoteLauncher } from './cursorRemoteLauncher';
const baseMetadata: Metadata = {
flavor: 'cursor',
path: '/tmp',
host: 'test'
};
function makeSession(): CursorSession {
return { path: '/tmp' } as CursorSession;
}
describe('cursorRemoteLauncher', () => {
beforeEach(() => {
legacyLauncher.mockClear();
acpLauncher.mockClear();
acpLauncher.mockResolvedValue('exit');
legacyLauncher.mockResolvedValue('exit');
});
it('uses ACP launcher for new sessions without cursorSessionId', async () => {
await cursorRemoteLauncher(makeSession(), baseMetadata);
expect(acpLauncher).toHaveBeenCalledTimes(1);
expect(legacyLauncher).not.toHaveBeenCalled();
});
it('uses legacy launcher only when metadata marks a pre-ACP session', async () => {
const legacyMetadata: Metadata = {
...baseMetadata,
cursorSessionId: 'old-stream-json-id',
cursorSessionProtocol: 'stream-json'
};
await cursorRemoteLauncher(makeSession(), legacyMetadata);
expect(legacyLauncher).toHaveBeenCalledTimes(1);
expect(acpLauncher).not.toHaveBeenCalled();
});
it('uses legacy launcher when cursorSessionId exists without protocol (pre-migration)', async () => {
const legacyMetadata: Metadata = {
...baseMetadata,
cursorSessionId: 'old-stream-json-id'
};
await cursorRemoteLauncher(makeSession(), legacyMetadata);
expect(legacyLauncher).toHaveBeenCalledTimes(1);
expect(acpLauncher).not.toHaveBeenCalled();
});
it('uses ACP launcher when cursorSessionProtocol is acp even with session id', async () => {
const acpMetadata: Metadata = {
...baseMetadata,
cursorSessionId: 'acp-session-id',
cursorSessionProtocol: 'acp'
};
await cursorRemoteLauncher(makeSession(), acpMetadata);
expect(acpLauncher).toHaveBeenCalledTimes(1);
expect(legacyLauncher).not.toHaveBeenCalled();
});
it('does not fallback to stream-json when the ACP launcher fails', async () => {
acpLauncher.mockRejectedValueOnce(new Error('Cursor ACP unavailable'));
await expect(cursorRemoteLauncher(makeSession(), baseMetadata)).rejects.toThrow('Cursor ACP unavailable');
expect(acpLauncher).toHaveBeenCalledTimes(1);
expect(legacyLauncher).not.toHaveBeenCalled();
});
it('does not fallback to stream-json when ACP resume fails for an acp-marked session', async () => {
const acpMetadata: Metadata = {
...baseMetadata,
cursorSessionId: 'acp-session-id',
cursorSessionProtocol: 'acp'
};
acpLauncher.mockRejectedValueOnce(new Error('Failed to resume Cursor ACP session'));
await expect(cursorRemoteLauncher(makeSession(), acpMetadata)).rejects.toThrow('Failed to resume Cursor ACP session');
expect(acpLauncher).toHaveBeenCalledTimes(1);
expect(legacyLauncher).not.toHaveBeenCalled();
});
});