From 062c1ea44d406d5c48152d479f15c8a830de70f8 Mon Sep 17 00:00:00 2001 From: Zef Hemel Date: Wed, 14 Jan 2026 08:33:29 +0100 Subject: [PATCH] Fix: addParentPointers re-attaches parents even if a sub-tree already has some + some cleanup Properly addresses #1776 --- client/markdown_renderer/markdown_render.ts | 5 +++++ plug-api/lib/tree.ts | 4 ---- plugs/index/refactor.ts | 1 - plugs/index/tags.ts | 2 -- 4 files changed, 5 insertions(+), 7 deletions(-) diff --git a/client/markdown_renderer/markdown_render.ts b/client/markdown_renderer/markdown_render.ts index c3f3bdef..23095a0b 100644 --- a/client/markdown_renderer/markdown_render.ts +++ b/client/markdown_renderer/markdown_render.ts @@ -43,10 +43,15 @@ function cleanTags(values: (Tag | null)[], cleanWhitespace = false): Tag[] { return result; } +/** + * Cleans up a markdown tree. Side effect: adds parent pointers + */ function preprocess(t: ParseTree) { addParentPointers(t); traverseTree(t, (node) => { + // If this node i if (!node.type) { + // Remove redundant newlines in table if (node.text?.startsWith("\n")) { const prevNodeIdx = node.parent!.children!.indexOf(node) - 1; const prevNodeType = node.parent!.children![prevNodeIdx]?.type; diff --git a/plug-api/lib/tree.ts b/plug-api/lib/tree.ts index be43612a..12f2f1cd 100644 --- a/plug-api/lib/tree.ts +++ b/plug-api/lib/tree.ts @@ -15,10 +15,6 @@ export function addParentPointers(tree: ParseTree) { return; } for (const child of tree.children) { - if (child.parent) { - // Already added parent pointers before - return; - } child.parent = tree; addParentPointers(child); } diff --git a/plugs/index/refactor.ts b/plugs/index/refactor.ts index a1d789d6..2fd5326c 100644 --- a/plugs/index/refactor.ts +++ b/plugs/index/refactor.ts @@ -49,7 +49,6 @@ export async function renamePageLinkCommand() { console.error("No link found at cursor position..."); return; } - console.log("Link node", mdTree); addParentPointers(mdTree); let node: ParseTree | null = link; if (node.type !== "WikiLink") { diff --git a/plugs/index/tags.ts b/plugs/index/tags.ts index 62b34148..9b955280 100644 --- a/plugs/index/tags.ts +++ b/plugs/index/tags.ts @@ -1,7 +1,6 @@ import type { FrontMatter } from "./frontmatter.ts"; import { queryLuaObjects } from "./api.ts"; import { - addParentPointers, collectNodesOfType, findParentMatching, type ParseTree, @@ -31,7 +30,6 @@ export function indexTags( tree: ParseTree, ) { const tags = new Set(); // name:parent - addParentPointers(tree); const pageTags: string[] = frontmatter.tags || []; for (const pageTag of pageTags) { tags.add(`${pageTag}:page`);