Matouš Jan FialkaandGitHub
e91bec71c0
This patch fixes the Lua arithmetic model at parser level only. Runtime level fixtures are left for future work. MOTIVATION Space Lua treats all numbers as IEEE-754 doubles (JS semantics), so it preserves negative zero. Lua uses integers and floats. The literal "-0" in Lua is parsed as unary minus applied to the integer literal "0", which yields the integer "0" (no sign). This difference flips the sign of the divisor in "1/-0" and "-1/-0". Although it could be fixed without touching the parser by changing only unary minus evaluation, this commit goes a little further and provides integer vs float differenciating at the parser level as well uses it to fix the unary minus evaluation. Extensive tests are added to test this exact change works and the Space Lua arithmetic model is aligned with Lua. Note that things like `-(expr)` in general may still produce results inconsistent with Lua. This cannot be fixed at parser level and must be fixed at runtime level which will need far more complex change to the Space Lua interpreter code. Therefor these cases we omitted from the tests. Signed-off-by: Matouš Jan Fialka <mjf@mjf.cz>
92 lines
4.5 KiB
Lua
92 lines
4.5 KiB
Lua
local function assert_eq(actual, expected, msg)
|
|
if actual ~= expected then
|
|
error('assert_eq failed: ' .. msg)
|
|
end
|
|
end
|
|
|
|
-- Integer-only (0 and -0 as integers)
|
|
-- Expectation: -0 is integer 0, so 1/-0 == +Inf, -1/-0 == +Inf
|
|
assert_eq( 1/ 0 == 1/ 0, true, 'int: 1/ 0 == 1/ 0')
|
|
assert_eq( 1/ 0 == -1/ 0, false, 'int: 1/ 0 == -1/ 0')
|
|
assert_eq( 1/ 0 == 1/-0, true, 'int: 1/ 0 == 1/-0')
|
|
assert_eq( 1/ 0 == -1/-0, false, 'int: 1/ 0 == -1/-0')
|
|
|
|
assert_eq( -1/ 0 == 1/ 0, false, 'int: -1/ 0 == 1/ 0')
|
|
assert_eq( -1/ 0 == -1/ 0, true, 'int: -1/ 0 == -1/ 0')
|
|
assert_eq( -1/ 0 == 1/-0, false, 'int: -1/ 0 == 1/-0')
|
|
assert_eq( -1/ 0 == -1/-0, true, 'int: -1/ 0 == -1/-0')
|
|
|
|
assert_eq( 1/-0 == 1/ 0, true, 'int: 1/-0 == 1/ 0')
|
|
assert_eq( 1/-0 == -1/ 0, false, 'int: 1/-0 == -1/ 0')
|
|
assert_eq( 1/-0 == 1/-0, true, 'int: 1/-0 == 1/-0')
|
|
assert_eq( 1/-0 == -1/-0, false, 'int: 1/-0 == -1/-0')
|
|
|
|
assert_eq( -1/-0 == 1/ 0, false, 'int: -1/-0 == 1/ 0')
|
|
assert_eq( -1/-0 == -1/ 0, true, 'int: -1/-0 == -1/0 ')
|
|
assert_eq( -1/-0 == 1/-0, false, 'int: -1/-0 == 1/-0')
|
|
assert_eq( -1/-0 == -1/-0, true, 'int: -1/-0 == -1/-0')
|
|
|
|
-- Float-only (0.0 and -0.0 as floats)
|
|
-- Expectation: -0.0 is float negative zero, so 1/-0.0 == -Inf, -1/-0.0 == +Inf
|
|
assert_eq( 1/ 0.0 == 1/ 0.0, true, 'float: 1/ 0.0 == 1/ 0.0')
|
|
assert_eq( 1/ 0.0 == -1/ 0.0, false, 'float: 1/ 0.0 == -1/ 0.0')
|
|
assert_eq( 1/ 0.0 == 1/-0.0, false, 'float: 1/ 0.0 == 1/-0.0')
|
|
assert_eq( 1/ 0.0 == -1/-0.0, true, 'float: 1/ 0.0 == -1/-0.0')
|
|
|
|
assert_eq( -1/ 0.0 == 1/ 0.0, false, 'float: -1/ 0.0 == 1/ 0.0')
|
|
assert_eq( -1/ 0.0 == -1/ 0.0, true, 'float: -1/ 0.0 == -1/ 0.0')
|
|
assert_eq( -1/ 0.0 == 1/-0.0, true, 'float: -1/ 0.0 == 1/-0.0')
|
|
assert_eq( -1/ 0.0 == -1/-0.0, false, 'float: -1/ 0.0 == -1/-0.0')
|
|
|
|
assert_eq( 1/-0.0 == 1/ 0.0, false, 'float: 1/-0.0 == 1/ 0.0')
|
|
assert_eq( 1/-0.0 == -1/ 0.0, true, 'float: 1/-0.0 == -1/ 0.0')
|
|
assert_eq( 1/-0.0 == 1/-0.0, true, 'float: 1/-0.0 == 1/-0.0')
|
|
assert_eq( 1/-0.0 == -1/-0.0, false, 'float: 1/-0.0 == -1/-0.0')
|
|
|
|
assert_eq( -1/-0.0 == 1/ 0.0, true, 'float: -1/-0.0 == 1/ 0.0')
|
|
assert_eq( -1/-0.0 == -1/ 0.0, false, 'float: -1/-0.0 == -1/ 0.0')
|
|
assert_eq( -1/-0.0 == 1/-0.0, false, 'float: -1/-0.0 == 1/-0.0')
|
|
assert_eq( -1/-0.0 == -1/-0.0, true, 'float: -1/-0.0 == -1/-0.0')
|
|
|
|
-- Integer-Float (left int 0/-0; right float 0.0/-0.0)
|
|
assert_eq( 1/ 0 == 1/ 0.0, true, 'int-float: 1/0 == 1/ 0.0')
|
|
assert_eq( 1/ 0 == -1/ 0.0, false, 'int-float: 1/0 == -1/ 0.0')
|
|
assert_eq( 1/ 0 == 1/-0.0, false, 'int-float: 1/0 == 1/-0.0')
|
|
assert_eq( 1/ 0 == -1/-0.0, true, 'int-float: 1/0 == -1/-0.0')
|
|
|
|
assert_eq( -1/ 0 == 1/ 0.0, false, 'int-float: -1/0 == 1/ 0.0')
|
|
assert_eq( -1/ 0 == -1/ 0.0, true, 'int-float: -1/0 == -1/ 0.0')
|
|
assert_eq( -1/ 0 == 1/-0.0, true, 'int-float: -1/0 == 1/-0.0')
|
|
assert_eq( -1/ 0 == -1/-0.0, false, 'int-float: -1/0 == -1/-0.0')
|
|
|
|
assert_eq( 1/-0 == 1/ 0.0, true, 'int-float: 1/-0 == 1/ 0.0')
|
|
assert_eq( 1/-0 == -1/ 0.0, false, 'int-float: 1/-0 == -1/ 0.0')
|
|
assert_eq( 1/-0 == 1/-0.0, false, 'int-float: 1/-0 == 1/-0.0')
|
|
assert_eq( 1/-0 == -1/-0.0, true, 'int-float: 1/-0 == -1/-0.0')
|
|
|
|
assert_eq( -1/-0 == 1/ 0.0, false, 'int-float: -1/-0 == 1/ 0.0')
|
|
assert_eq( -1/-0 == -1/ 0.0, true, 'int-float: -1/-0 == -1/ 0.0')
|
|
assert_eq( -1/-0 == 1/-0.0, true, 'int-float: -1/-0 == 1/-0.0')
|
|
assert_eq( -1/-0 == -1/-0.0, false, 'int-float: -1/-0 == -1/-0.0')
|
|
|
|
-- Float-Integer (left float 0.0/-0.0; right int 0/-0)
|
|
assert_eq( 1/ 0.0 == 1/ 0, true, 'float-int: 1/0.0 == 1/ 0')
|
|
assert_eq( 1/ 0.0 == -1/ 0, false, 'float-int: 1/0.0 == -1/ 0')
|
|
assert_eq( 1/ 0.0 == 1/-0, true, 'float-int: 1/0.0 == 1/-0')
|
|
assert_eq( 1/ 0.0 == -1/-0, false, 'float-int: 1/0.0 == -1/-0')
|
|
|
|
assert_eq( -1/ 0.0 == 1/ 0, false, 'float-int: -1/0.0 == 1/ 0')
|
|
assert_eq( -1/ 0.0 == -1/ 0, true, 'float-int: -1/0.0 == -1/ 0')
|
|
assert_eq( -1/ 0.0 == 1/-0, false, 'float-int: -1/0.0 == 1/-0')
|
|
assert_eq( -1/ 0.0 == -1/-0, true, 'float-int: -1/0.0 == -1/-0')
|
|
|
|
assert_eq( 1/-0.0 == 1/ 0, false, 'float-int: 1/-0.0 == 1/ 0')
|
|
assert_eq( 1/-0.0 == -1/ 0, true, 'float-int: 1/-0.0 == -1/ 0')
|
|
assert_eq( 1/-0.0 == 1/-0, false, 'float-int: 1/-0.0 == 1/-0')
|
|
assert_eq( 1/-0.0 == -1/-0, true, 'float-int: 1/-0.0 == -1/-0')
|
|
|
|
assert_eq( -1/-0.0 == 1/ 0, true, 'float-int: -1/-0.0 == 1/ 0')
|
|
assert_eq( -1/-0.0 == -1/ 0, false, 'float-int: -1/-0.0 == -1/ 0')
|
|
assert_eq( -1/-0.0 == 1/-0, true, 'float-int: -1/-0.0 == 1/-0')
|
|
assert_eq( -1/-0.0 == -1/-0, false, 'float-int: -1/-0.0 == -1/-0')
|